fix: Parse Retry-After header for 429s#474
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Open
Conversation
We remove retry logic from the background logger, and move it into the http adapter layer. This means we only retry on meaningful errors, like network issues or 429s. If we hit 429s, we now also correctly parse the Retry-After header to determine what the exponential backoff should be.
Abhijeet Prasad (AbhiPrasad)
requested review from
David Elner (delner) and
Andrew Kent (realark)
Andrew Kent (realark)
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we actually had two levels of retries for "failed" requests to braintrust:
/logs3failedThis PR cleans that up to remove the background worker thread retries, and make the http transport layer (via the retry adapter) the only source of truth for retries. After that change, it adds support for retrying on 429s to the retry adapter, leveraging the
Retry-Afterheader to determine when to properly do backoffs.dependent on https://github.com/braintrustdata/braintrust/pull/14886 deploying as that fixes how we send
Retry-After